Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Popover misses outside clicks when the clicked control stops propagation. This leaves the Employers account menu open above a candidate profile.
Task: MON-147500. Related Employers MR: !5017.
What changed
polaris-glints.Scope
One listener setting. No new listeners, API changes, touch-handler changes, or committed UI tests. Existing business-logic tests are untouched.
Tradeoffs
The shared fix avoids duplicating outside-click listeners in consumers. Outside-click
onClosenow runs before target click handlers. Existing content, activator, child-overlay, and transition checks remain unchanged.Blast radius
All Polaris Popover consumers receive the new click ordering after upgrading. Global EventListener defaults are unchanged. Aries and Employers are not upgraded by this PR. Keep the Employers workaround until the fixed dependency is released and adopted.
Verification
menuState=open, candidateOpened=true, closeCalls=0. After the same click:menuState=closed, candidateOpened=true, closeCalls=1. No production or shared staging data was changed.build:types, focused ESLint, Prettier, and independent correctness and comment review pass.glints-portal-containersetup. With a temporary, uncommitted portal setup, both versions have 50 passing and the same 4 failing cases: two stale fixed-ID expectations and two portal-container expectations. No new failures. Root typecheck fails because this fork references absent workspace packages; the affected workspace typecheck passes. This is not a green native test suite or deployed Employers verification.Screenshots below show the same local real-component fixture, not a deployed Employers page. Images are hosted in the related GitLab project and may require Glints GitLab access.
Follow-up
After maintainer review and package release, update the Polaris dependency in Aries, release Aries, upgrade Employers, and remove the UserMenu-specific listener and supporting hooks. No merge or package publication was performed as part of this change.